Skip to content

Add entity translations to Rainmachine#96033

Merged
frenck merged 2 commits into
home-assistant:devfrom
joostlek:rainmachine_entity_translations
Jul 7, 2023
Merged

Add entity translations to Rainmachine#96033
frenck merged 2 commits into
home-assistant:devfrom
joostlek:rainmachine_entity_translations

Conversation

@joostlek
Copy link
Copy Markdown
Member

@joostlek joostlek commented Jul 6, 2023

Proposed change

Add entity translations to Rainmachine. 2 sensors use combined naming so they are skipped.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 6, 2023

Hey there @bachya, mind taking a look at this pull request as it has been labeled with an integration (rainmachine) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rainmachine can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign rainmachine Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Comment thread homeassistant/components/rainmachine/update.py
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 7, 2023
@bachya
Copy link
Copy Markdown
Contributor

bachya commented Jul 7, 2023

Something is off here—this PR is overwriting names with the same string. As an example, see a sample of the Diagnostic sensors before the PR:

CleanShot 2023-07-07 at 08 58 52

...and after:

CleanShot 2023-07-07 at 08 57 55

@joostlek
Copy link
Copy Markdown
Member Author

joostlek commented Jul 7, 2023

Are you running this on your local machine? Have you regenerated the translations?

@bachya
Copy link
Copy Markdown
Contributor

bachya commented Jul 7, 2023

🤦🏻

After generating, looks functionally correct!

@joostlek
Copy link
Copy Markdown
Member Author

joostlek commented Jul 7, 2023

🤦🏻

After generating, looks functionally correct!

Haha, don't worry, even after this many PRs I forget it sometimes.

Comment thread homeassistant/components/rainmachine/update.py
@home-assistant home-assistant Bot marked this pull request as draft July 7, 2023 15:44
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Jul 7, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek joostlek marked this pull request as ready for review July 7, 2023 15:45
@home-assistant home-assistant Bot requested a review from frenck July 7, 2023 15:45
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck merged commit 29d7535 into home-assistant:dev Jul 7, 2023
@joostlek joostlek deleted the rainmachine_entity_translations branch July 7, 2023 16:38
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality integration: rainmachine Quality Scale: No score smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants